Shader woes - Socoder

-=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- (c) WidthPadding Industries 1987 0\|765\|0 -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=-
Socoder -> C/C++/C#/Other -> Shader woes
Sun, 13 Aug 2017, 04:55
Afr0	Shader woes I'm guessing that noone here are particularly good with shaders (specifically: HLSL), but in case you are, can you spot what's wrong with this? float4x4 World; float4x4 View; float4x4 Projection; float4 AmbientColor = float4(1, 1, 1, 1); float AmbientIntensity = 0.1; texture HeadTexture; sampler HeadTextureSampler = sampler_state { Texture = <HeadTexture>; }; texture AccessoryTexture; sampler AccessoryTextureSampler = sampler_state { Texture = <AccessoryTexture>; }; texture LeftHandTexture; sampler LeftHandTextureSampler = sampler_state { Texture = <LeftHandTexture>; }; texture RightHandTexture; sampler RightHandTextureSampler = sampler_state { Texture = <RightHandTexture>; }; struct VertexShaderHeadInput { float4 Position : POSITION0; float4 Normal : NORMAL0; float4 TexPosition : TEXCOORD0; }; struct VertexShaderHeadOutput { float4 Position : POSITION0; float4 Normal : NORMAL0; float4 TexPosition : TEXCOORD0; }; VertexShaderHeadOutput TransformHead(VertexShaderHeadInput Input) { VertexShaderHeadOutput Output; float4 WorldPosition = mul(Input.Position, World); float4 ViewPosition = mul(WorldPosition, View); Output.Position = mul(ViewPosition, Projection); Output.Normal = mul(ViewPosition, Projection); Output.TexPosition = Input.TexPosition; return Output; } VertexShaderHeadOutput TransformAccessory(VertexShaderHeadInput Input) { VertexShaderHeadOutput Output; float4 WorldPosition = mul(Input.Position, World); float4 ViewPosition = mul(WorldPosition, View); Output.Position = mul(ViewPosition, Projection); Output.Normal = mul(ViewPosition, Projection); Output.TexPosition = Input.TexPosition; return Output; } VertexShaderHeadOutput TransformLeftHand(VertexShaderHeadInput Input) { VertexShaderHeadOutput Output; float4 WorldPosition = mul(Input.Position, World); float4 ViewPosition = mul(WorldPosition, View); Output.Position = mul(ViewPosition, Projection); Output.Normal = mul(ViewPosition, Projection); Output.TexPosition = Input.TexPosition; return Output; } VertexShaderHeadOutput TransformRightHand(VertexShaderHeadInput Input) { VertexShaderHeadOutput Output; float4 WorldPosition = mul(Input.Position, World); float4 ViewPosition = mul(WorldPosition, View); Output.Position = mul(ViewPosition, Projection); Output.Normal = mul(ViewPosition, Projection); Output.TexPosition = Input.TexPosition; return Output; } float4 HeadPixelShaderFunction(VertexShaderHeadOutput Input) : COLOR0 { float4 Color = tex2D(HeadTextureSampler, Input.TexPosition); return Color; } float4 AccessoryPixelShaderFunction(VertexShaderHeadOutput Input) : COLOR0 { float4 Color = tex2D(AccessoryTextureSampler, Input.TexPosition); return Color; } float4 LeftHandPixelShaderFunction(VertexShaderHeadOutput Input) : COLOR0 { float4 Color = tex2D(LeftHandTextureSampler, Input.TexPosition); return Color; } float4 RightHandPixelShaderFunction(VertexShaderHeadOutput Input) : COLOR0 { float4 Color = tex2D(RightHandTextureSampler, Input.TexPosition); return Color; } technique TransformHeadTechnique { pass HeadPass { VertexShader = compile vs_3_0 TransformHead(); PixelShader = compile ps_3_0 HeadPixelShaderFunction(); } } technique TransformAccessoryTechnique { pass HeadPass { VertexShader = compile vs_3_0 TransformAccessory(); PixelShader = compile ps_3_0 AccessoryPixelShaderFunction(); } } technique TransformLeftHandTechnique { pass HeadPass { VertexShader = compile vs_3_0 TransformLeftHand(); PixelShader = compile ps_3_0 LeftHandPixelShaderFunction(); } } technique TransformRightHandTechnique { pass HeadPass { VertexShader = compile vs_3_0 TransformRightHand(); PixelShader = compile ps_3_0 RightHandPixelShaderFunction(); } } --v All the bones keep rotating around the X axis when they're only supposed to rotate around the Y. Here's how I create the rotation: /// <summary> /// Converts an angle given in degrees to radians. /// </summary> /// <param name="Angle">The angle to convert.</param> /// <returns>The angle in radians.</returns> private double DegreesToRadians(double Angle) { return (Math.PI / 180) * Angle; } /// <summary> /// Updates this avatar's rotation. /// </summary> /// <param name="GTime">A GameTime instance.</param> public void Update(GameTime GTime) { if (ShouldRotate) { float Time = GTime.TotalGameTime.Ticks; float Phase = (Time % RotationSpeed) / RotationSpeed; double Multiplier = Math.Sin((Math.PI * 2) * Phase); double NewAngle = RotationStartAngle + (RotationRange * Multiplier); RotationY = (float)DegreesToRadians(NewAngle); } } --v -=-=- Afr0 Games Project Dollhouse on Github - Please fork!
Sun, 13 Aug 2017, 05:08
Jayenkai	I know nothing of shaders, or 3D in general I'm afraid. The last 3D stuff I did was .. Oh, actually it was that Xmas card I made, last year.. Hmm. Either way, that was still in Blitz3D, so is barely relevant, here. Is it only X and Y, not Z, too? I ask because I remember having a lot of "It's rotating wrong" issues when I was unsure whether to rotate based on Object or World. That stuff really did my head in, and I could never quite get rotations to work as expected. Do Shaders even do Object/World things?! This post isn't useful at all, is it!?! -=-=- ''Load, Next List!''
Sun, 13 Aug 2017, 05:17
Afr0	Yeah the shader transforms based on the world position and the view position. It's possible that I'm sending those incorrectly to the shader somehow :\| If you're interested, here's how i'm doing it: /This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed with this file, You can obtain one at https://mozilla.org/MPL/2.0/. The Original Code is the Vitaboy library. The Initial Developer of the Original Code is Mats 'Afr0' Vederhus. All Rights Reserved. Contributor(s): / using System; using System.Linq; using Files.Vitaboy; using Files.Manager; using Microsoft.Xna.Framework; using Microsoft.Xna.Framework.Graphics; namespace Vitaboy { public enum SkinType { Light = 0, Medium = 1, Dark = 2 } internal enum MeshType { Body = 0, Head = 1, LHand = 2, RHand = 3 } /// <summary> /// Class for drawing and updating the meshes that make up an avatar. /// Also responsible for animating an avatar. /// </summary> public class AvatarBase : IDisposable { protected GraphicsDevice m_Devc; public Skeleton Skel; protected Effect m_VitaboyShader; protected BasicEffect m_BodyEffect, m_HeadEffect, m_AccessoryEffect, m_LeftHandEffect, RightHandEffect; public Mesh HeadMesh, AccessoryMesh, BodyMesh, LeftHandMesh, RightHandMesh; public Texture2D LeftHandTexture, RightHandTexture, BodyTexture, HeadTexture, AccessoryTexture; public Anim Animation; private float m_AnimationTime = 0.0f; private bool m_GPURender = false; public float RotationStartAngle = 0.0f; public float RotationSpeed = new TimeSpan(0, 0, 10).Ticks; public float RotationRange = 40.0f; /// <summary> /// Should this avatar be rotated when rendered? /// Used for rendering in UI. /// </summary> public bool ShouldRotate = false; private bool m_WorldIsDirty = false; private Matrix m_World; private float m_RotateX = 0.0f, m_RotateY = 0.0f, m_RotateZ = 0.0f; private float m_Scale = 1.0f; private Vector3 m_Position = new Vector3(0.0f, 0.0f, 0.0f); /// <summary> /// This avatar's world matrix. Used for rendering. /// </summary> public Matrix WorldMatrix { get { if (m_WorldIsDirty) { m_World = Matrix.CreateRotationX(m_RotateX) * Matrix.CreateRotationY(m_RotateY) * Matrix.CreateRotationZ(m_RotateZ) * Matrix.CreateScale(m_Scale) * Matrix.CreateTranslation(m_Position); m_WorldIsDirty = false; } return m_World; } } /// <summary> /// Gets or sets the angle (in degrees) of the rotation axis for this Avatar. /// </summary> public float RotationY { get { return m_RotateY; } set { m_RotateY = value; m_WorldIsDirty = true; } } /// <summary> /// Changes this avatar's outfit. /// </summary> public void ChangeOutfit(Outfit Oft, SkinType Type) { Binding[] Bindings; AccessoryMesh = null; AccessoryTexture = null; if (Oft.HandgroupID.FileID != 0) { HandGroup Hag = FileManager.GetHandgroup(Oft.HandgroupID.UniqueID); Appearance LeftHandApr, RightHandApr; switch (Type) { case SkinType.Light: LeftHandApr = FileManager.GetAppearance(Hag.Light.Left.Idle.AppearanceID.UniqueID); RightHandApr = FileManager.GetAppearance(Hag.Light.Right.Idle.AppearanceID.UniqueID); break; case SkinType.Medium: LeftHandApr = FileManager.GetAppearance(Hag.Medium.Left.Idle.AppearanceID.UniqueID); RightHandApr = FileManager.GetAppearance(Hag.Medium.Right.Idle.AppearanceID.UniqueID); break; case SkinType.Dark: LeftHandApr = FileManager.GetAppearance(Hag.Dark.Left.Idle.AppearanceID.UniqueID); RightHandApr = FileManager.GetAppearance(Hag.Dark.Right.Idle.AppearanceID.UniqueID); break; default: LeftHandApr = FileManager.GetAppearance(Hag.Light.Left.Idle.AppearanceID.UniqueID); RightHandApr = FileManager.GetAppearance(Hag.Light.Right.Idle.AppearanceID.UniqueID); break; } Bindings = FileManager.GetBindings(LeftHandApr.BindingIDs); foreach (Binding Bnd in Bindings) { switch (Bnd.Bone) { case "L_HAND": LeftHandMesh = FileManager.GetMesh(Bnd.MeshID.UniqueID); LeftHandTexture = FileManager.GetTexture(Bnd.TextureID.UniqueID); break; } } Bindings = FileManager.GetBindings(RightHandApr.BindingIDs); foreach (Binding Bnd in Bindings) { switch (Bnd.Bone) { case "R_HAND": RightHandMesh = FileManager.GetMesh(Bnd.MeshID.UniqueID); RightHandTexture = FileManager.GetTexture(Bnd.TextureID.UniqueID); break; } } } Appearance Apr; switch (Type) { case SkinType.Light: Apr = FileManager.GetAppearance(Oft.LightAppearance.UniqueID); break; case SkinType.Medium: Apr = FileManager.GetAppearance(Oft.MediumAppearance.UniqueID); break; case SkinType.Dark: Apr = FileManager.GetAppearance(Oft.DarkAppearance.UniqueID); break; default: Apr = FileManager.GetAppearance(Oft.LightAppearance.UniqueID); break; } Bindings = FileManager.GetBindings(Apr.BindingIDs); if(Oft.Region == OutfitRegion.Head) HeadMesh = null; //IMPORTANT: Reset the head mesh before loading a new one. foreach (Binding Bnd in Bindings) { switch (Bnd.Bone) { case "PELVIS": BodyMesh = FileManager.GetMesh(Bnd.MeshID.UniqueID); BodyTexture = FileManager.GetTexture(Bnd.TextureID.UniqueID); break; case "HEAD": if (HeadMesh == null) { HeadMesh = FileManager.GetMesh(Bnd.MeshID.UniqueID); HeadTexture = FileManager.GetTexture(Bnd.TextureID.UniqueID); } else { AccessoryMesh = FileManager.GetMesh(Bnd.MeshID.UniqueID); AccessoryTexture = FileManager.GetTexture(Bnd.TextureID.UniqueID); } break; } } } /// <summary> /// Sets this avatar's head outfit. /// </summary> public void SetHead(Outfit HeadOutfit, SkinType Type) { Appearance Apr; switch (Type) { case SkinType.Light: Apr = FileManager.GetAppearance(HeadOutfit.LightAppearance.UniqueID); break; case SkinType.Medium: Apr = FileManager.GetAppearance(HeadOutfit.MediumAppearance.UniqueID); break; case SkinType.Dark: Apr = FileManager.GetAppearance(HeadOutfit.DarkAppearance.UniqueID); break; default: Apr = FileManager.GetAppearance(HeadOutfit.LightAppearance.UniqueID); break; } AccessoryMesh = null; AccessoryTexture = null; //I think that heads are always 0... Binding Bnd = FileManager.GetBinding(Apr.BindingIDs[0].UniqueID); HeadMesh = FileManager.GetMesh(Bnd.MeshID.UniqueID); HeadTexture = FileManager.GetTexture(Bnd.TextureID.UniqueID); if(Apr.BindingIDs.Count > 1) //This head has accessories. Bnd = FileManager.GetBinding(Apr.BindingIDs[1].UniqueID); } /// <summary> /// Creates a new instance of AvatarBase. /// </summary> /// <param name="Devc">A GraphicsDevice instance.</param> /// <param name="Skel">A Skeleton instance.</param> public AvatarBase(GraphicsDevice Devc, Skeleton Skel, Effect HeadShader = null) { m_Devc = Devc; this.Skel = Skel; m_HeadEffect = new BasicEffect(Devc); m_AccessoryEffect = new BasicEffect(Devc); m_BodyEffect = new BasicEffect(Devc); m_LeftHandEffect = new BasicEffect(Devc); if (HeadShader != null) { m_GPURender = true; m_VitaboyShader = HeadShader; } } /// <summary> /// Converts an angle given in degrees to radians. /// </summary> /// <param name="Angle">The angle to convert.</param> /// <returns>The angle in radians.</returns> private double DegreesToRadians(double Angle) { return (Math.PI / 180) * Angle; } /// <summary> /// Updates this avatar's rotation. /// </summary> /// <param name="GTime">A GameTime instance.</param> public void Update(GameTime GTime) { if (ShouldRotate) { float Time = GTime.TotalGameTime.Ticks; float Phase = (Time % RotationSpeed) / RotationSpeed; double Multiplier = Math.Sin((Math.PI * 2) * Phase); double NewAngle = RotationStartAngle + (RotationRange * Multiplier); RotationY = (float)DegreesToRadians(NewAngle); } } /// <summary> /// Renders the different meshes making up this avatar. /// </summary> /// <param name="ViewMatrix">A view matrix.</param> /// <param name="WorldMatrix">A world matrix.</param> /// <param name="ProjectionMatrix">A projection matrix.</param> public void Render(Matrix ViewMatrix, Matrix WorldMatrix, Matrix ProjectionMatrix) { //This sets DepthBufferEnable and DepthBufferWriteEnable. m_Devc.DepthStencilState = DepthStencilState.Default; m_Devc.BlendState = BlendState.AlphaBlend; m_Devc.RasterizerState = RasterizerState.CullNone; if (m_GPURender == false) { // Configure effects m_HeadEffect.World = WorldMatrix; m_HeadEffect.View = ViewMatrix; m_HeadEffect.Projection = ProjectionMatrix; m_HeadEffect.EnableDefaultLighting(); } else { m_VitaboyShader.Parameters["View"].SetValue(ViewMatrix); m_VitaboyShader.Parameters["Projection"].SetValue(ProjectionMatrix); } if (HeadTexture != null) { if (m_GPURender == false) { m_HeadEffect.Texture = HeadTexture; m_HeadEffect.TextureEnabled = true; } else m_VitaboyShader.Parameters["HeadTexture"].SetValue(HeadTexture); } if (m_GPURender == false) { m_AccessoryEffect.World = WorldMatrix; m_AccessoryEffect.View = ViewMatrix; m_AccessoryEffect.Projection = ProjectionMatrix; m_AccessoryEffect.EnableDefaultLighting(); } if (AccessoryTexture != null) { if (m_GPURender == false) { m_AccessoryEffect.Texture = AccessoryTexture; m_AccessoryEffect.TextureEnabled = true; } else m_VitaboyShader.Parameters["AccessoryTexture"].SetValue(AccessoryTexture); } m_BodyEffect.World = WorldMatrix; m_BodyEffect.View = ViewMatrix; m_BodyEffect.Projection = ProjectionMatrix; m_BodyEffect.EnableDefaultLighting(); if (m_BodyEffect != null) { m_BodyEffect.Texture = BodyTexture; m_BodyEffect.TextureEnabled = true; } // Configure effects m_LeftHandEffect.World = WorldMatrix; m_LeftHandEffect.View = ViewMatrix; m_LeftHandEffect.Projection = ProjectionMatrix; m_LeftHandEffect.EnableDefaultLighting(); if (LeftHandTexture != null) { if (m_GPURender == false) { m_LeftHandEffect.Texture = LeftHandTexture; m_LeftHandEffect.TextureEnabled = true; } else m_VitaboyShader.Parameters["LeftHandTexture"].SetValue(LeftHandTexture); } if (RightHandTexture != null) { if(m_GPURender) m_VitaboyShader.Parameters["RightHandTexture"].SetValue(RightHandTexture); } if (HeadMesh != null) { if (m_GPURender == false) { foreach (EffectPass Pass in m_HeadEffect.CurrentTechnique.Passes) { Pass.Apply(); foreach (Vector3 Fce in HeadMesh.Faces) { // Draw VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = HeadMesh.TransformedVertices[(int)Fce.X]; Vertex[1] = HeadMesh.TransformedVertices[(int)Fce.Y]; Vertex[2] = HeadMesh.TransformedVertices[(int)Fce.Z]; Vertex[0].TextureCoordinate = HeadMesh.TransformedVertices[(int)Fce.X].TextureCoordinate; Vertex[1].TextureCoordinate = HeadMesh.TransformedVertices[(int)Fce.Y].TextureCoordinate; Vertex[2].TextureCoordinate = HeadMesh.TransformedVertices[(int)Fce.Z].TextureCoordinate; Vertex[0].Normal = HeadMesh.TransformedVertices[(int)Fce.X].Normal; Vertex[1].Normal = HeadMesh.TransformedVertices[(int)Fce.Y].Normal; Vertex[2].Normal = HeadMesh.TransformedVertices[(int)Fce.Z].Normal; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } TransformVertices(HeadMesh, null, MeshType.Head); } } else { m_VitaboyShader.Parameters["World"].SetValue(WorldMatrix * Skel.Bones[Skel.FindBone("HEAD")].AbsoluteMatrix); foreach (EffectPass Pass in m_VitaboyShader.Techniques["TransformHeadTechnique"].Passes) { Pass.Apply(); foreach (Vector3 Fce in HeadMesh.Faces) { VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = HeadMesh.RealVertices[(int)Fce.X]; Vertex[1] = HeadMesh.RealVertices[(int)Fce.Y]; Vertex[2] = HeadMesh.RealVertices[(int)Fce.Z]; Vertex[0].TextureCoordinate = HeadMesh.RealVertices[(int)Fce.X].TextureCoordinate; Vertex[1].TextureCoordinate = HeadMesh.RealVertices[(int)Fce.Y].TextureCoordinate; Vertex[2].TextureCoordinate = HeadMesh.RealVertices[(int)Fce.Z].TextureCoordinate; Vertex[0].Normal = HeadMesh.RealVertices[(int)Fce.X].Normal; Vertex[1].Normal = HeadMesh.RealVertices[(int)Fce.Y].Normal; Vertex[2].Normal = HeadMesh.RealVertices[(int)Fce.Z].Normal; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } } } } if (AccessoryMesh != null) { if (m_GPURender == false) { foreach (EffectPass Pass in m_AccessoryEffect.CurrentTechnique.Passes) { Pass.Apply(); foreach (Vector3 Fce in AccessoryMesh.Faces) { // Draw VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = AccessoryMesh.TransformedVertices[(int)Fce.X]; Vertex[1] = AccessoryMesh.TransformedVertices[(int)Fce.Y]; Vertex[2] = AccessoryMesh.TransformedVertices[(int)Fce.Z]; Vertex[0].TextureCoordinate = AccessoryMesh.TransformedVertices[(int)Fce.X].TextureCoordinate; Vertex[1].TextureCoordinate = AccessoryMesh.TransformedVertices[(int)Fce.Y].TextureCoordinate; Vertex[2].TextureCoordinate = AccessoryMesh.TransformedVertices[(int)Fce.Z].TextureCoordinate; Vertex[0].Normal = AccessoryMesh.TransformedVertices[(int)Fce.X].Normal; Vertex[1].Normal = AccessoryMesh.TransformedVertices[(int)Fce.Y].Normal; Vertex[2].Normal = AccessoryMesh.TransformedVertices[(int)Fce.Z].Normal; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } TransformVertices(AccessoryMesh, null, MeshType.Head); } } else { m_VitaboyShader.Parameters["World"].SetValue(WorldMatrix * Skel.Bones[Skel.FindBone("HEAD")].AbsoluteMatrix); foreach (EffectPass Pass in m_VitaboyShader.Techniques["TransformAccessoryTechnique"].Passes) { Pass.Apply(); foreach (Vector3 Fce in AccessoryMesh.Faces) { VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = AccessoryMesh.RealVertices[(int)Fce.X]; Vertex[1] = AccessoryMesh.RealVertices[(int)Fce.Y]; Vertex[2] = AccessoryMesh.RealVertices[(int)Fce.Z]; Vertex[0].TextureCoordinate = AccessoryMesh.RealVertices[(int)Fce.X].TextureCoordinate; Vertex[1].TextureCoordinate = AccessoryMesh.RealVertices[(int)Fce.Y].TextureCoordinate; Vertex[2].TextureCoordinate = AccessoryMesh.RealVertices[(int)Fce.Z].TextureCoordinate; Vertex[0].Normal = AccessoryMesh.RealVertices[(int)Fce.X].Normal; Vertex[1].Normal = AccessoryMesh.RealVertices[(int)Fce.Y].Normal; Vertex[2].Normal = AccessoryMesh.RealVertices[(int)Fce.Z].Normal; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } } } } if (BodyMesh != null) { foreach (EffectPass Pass in m_BodyEffect.CurrentTechnique.Passes) { Pass.Apply(); foreach (Vector3 Fce in BodyMesh.Faces) { // Draw VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = BodyMesh.TransformedVertices[(int)Fce.X]; Vertex[1] = BodyMesh.TransformedVertices[(int)Fce.Y]; Vertex[2] = BodyMesh.TransformedVertices[(int)Fce.Z]; Vertex[0].TextureCoordinate = BodyMesh.TransformedVertices[(int)Fce.X].TextureCoordinate; Vertex[1].TextureCoordinate = BodyMesh.TransformedVertices[(int)Fce.Y].TextureCoordinate; Vertex[2].TextureCoordinate = BodyMesh.TransformedVertices[(int)Fce.Z].TextureCoordinate; Vertex[0].Normal = BodyMesh.TransformedVertices[(int)Fce.X].Normal; Vertex[1].Normal = BodyMesh.TransformedVertices[(int)Fce.Y].Normal; Vertex[2].Normal = BodyMesh.TransformedVertices[(int)Fce.Z].Normal; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } TransformVertices(BodyMesh, Skel.Bones[Skel.FindBone("PELVIS")], MeshType.Body); } } if (LeftHandMesh != null) { if (m_GPURender == false) { foreach (EffectPass Pass in m_LeftHandEffect.CurrentTechnique.Passes) { Pass.Apply(); foreach (Vector3 Fce in LeftHandMesh.Faces) { // Draw VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = LeftHandMesh.TransformedVertices[(int)Fce.X]; Vertex[1] = LeftHandMesh.TransformedVertices[(int)Fce.Y]; Vertex[2] = LeftHandMesh.TransformedVertices[(int)Fce.Z]; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } TransformVertices(LeftHandMesh, null, MeshType.LHand); } } else { m_VitaboyShader.Parameters["World"].SetValue(WorldMatrix * Skel.Bones[Skel.FindBone("L_HAND")].AbsoluteMatrix); foreach (EffectPass Pass in m_VitaboyShader.Techniques["TransformLeftHandTechnique"].Passes) { Pass.Apply(); foreach (Vector3 Fce in LeftHandMesh.Faces) { VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = LeftHandMesh.RealVertices[(int)Fce.X]; Vertex[1] = LeftHandMesh.RealVertices[(int)Fce.Y]; Vertex[2] = LeftHandMesh.RealVertices[(int)Fce.Z]; Vertex[0].TextureCoordinate = LeftHandMesh.RealVertices[(int)Fce.X].TextureCoordinate; Vertex[1].TextureCoordinate = LeftHandMesh.RealVertices[(int)Fce.Y].TextureCoordinate; Vertex[2].TextureCoordinate = LeftHandMesh.RealVertices[(int)Fce.Z].TextureCoordinate; Vertex[0].Normal = LeftHandMesh.RealVertices[(int)Fce.X].Normal; Vertex[1].Normal = LeftHandMesh.RealVertices[(int)Fce.Y].Normal; Vertex[2].Normal = LeftHandMesh.RealVertices[(int)Fce.Z].Normal; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } } } } if (RightHandMesh != null) { if (m_GPURender == false) { foreach (EffectPass Pass in m_LeftHandEffect.CurrentTechnique.Passes) { Pass.Apply(); foreach (Vector3 Fce in RightHandMesh.Faces) { // Draw VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = RightHandMesh.TransformedVertices[(int)Fce.X]; Vertex[1] = RightHandMesh.TransformedVertices[(int)Fce.Y]; Vertex[2] = RightHandMesh.TransformedVertices[(int)Fce.Z]; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } TransformVertices(RightHandMesh, null, MeshType.RHand); } } else { m_VitaboyShader.Parameters["World"].SetValue(WorldMatrix * Skel.Bones[Skel.FindBone("R_HAND")].AbsoluteMatrix); foreach (EffectPass Pass in m_VitaboyShader.Techniques["TransformRightHandTechnique"].Passes) { Pass.Apply(); foreach (Vector3 Fce in RightHandMesh.Faces) { VertexPositionNormalTexture[] Vertex = new VertexPositionNormalTexture[3]; Vertex[0] = RightHandMesh.RealVertices[(int)Fce.X]; Vertex[1] = RightHandMesh.RealVertices[(int)Fce.Y]; Vertex[2] = RightHandMesh.RealVertices[(int)Fce.Z]; Vertex[0].TextureCoordinate = RightHandMesh.RealVertices[(int)Fce.X].TextureCoordinate; Vertex[1].TextureCoordinate = RightHandMesh.RealVertices[(int)Fce.Y].TextureCoordinate; Vertex[2].TextureCoordinate = RightHandMesh.RealVertices[(int)Fce.Z].TextureCoordinate; Vertex[0].Normal = RightHandMesh.RealVertices[(int)Fce.X].Normal; Vertex[1].Normal = RightHandMesh.RealVertices[(int)Fce.Y].Normal; Vertex[2].Normal = RightHandMesh.RealVertices[(int)Fce.Z].Normal; m_Devc.DrawUserPrimitives(PrimitiveType.TriangleList, Vertex, 0, 1); } } } } } /// <summary> /// Transforms all vertices in a given mesh to their correct positions. /// </summary> /// <param name="Msh">The mesh to transform.</param> /// <param name="bone">The bone to transform to.</param> private void TransformVertices(Mesh Msh, Bone bone, MeshType MshType) { switch (MshType) { case MeshType.Head: for (int i = 0; i < Msh.TotalVertexCount; i++) { //Transform the head vertices' position by the absolute transform //for the headbone (which is always bone 17) to render the head in place. Msh.TransformedVertices[i].Position = Vector3.Transform(Msh.RealVertices[i].Position, Skel.Bones[Skel.FindBone("HEAD")].AbsoluteMatrix); Msh.TransformedVertices[i].TextureCoordinate = Msh.RealVertices[i].TextureCoordinate; //Transform the head normals' position by the absolute transform //for the headbone (which is always bone 17) to render the head in place. Msh.TransformedVertices[i].Normal = Vector3.Transform(Msh.RealVertices[i].Normal, Skel.Bones[Skel.FindBone("HEAD")].AbsoluteMatrix); } return; case MeshType.Body: BoneBinding boneBinding = Msh.BoneBindings.FirstOrDefault(x => Msh.Bones[(int)x.BoneIndex] == bone.Name); if (boneBinding != null) { for (int i = 0; i < boneBinding.RealVertexCount; i++) { int vertexIndex = (int)boneBinding.FirstRealVertexIndex + i; VertexPositionNormalTexture relativeVertex = Msh.RealVertices[vertexIndex]; Matrix translatedMatrix = Matrix.CreateTranslation(new Vector3(relativeVertex.Position.X, relativeVertex.Position.Y, relativeVertex.Position.Z)) * bone.AbsoluteMatrix; Msh.TransformedVertices[vertexIndex].Position = Vector3.Transform(Vector3.Zero, translatedMatrix); Msh.TransformedVertices[vertexIndex].TextureCoordinate = relativeVertex.TextureCoordinate; //Normals... translatedMatrix = Matrix.CreateTranslation(new Vector3(relativeVertex.Normal.X, relativeVertex.Normal.Y, relativeVertex.Normal.Z)) * bone.AbsoluteMatrix; Msh.TransformedVertices[vertexIndex].Normal = Vector3.Transform(Vector3.Zero, translatedMatrix); } } foreach (var child in bone.Children) TransformVertices(Msh, child, MshType); break; case MeshType.LHand: for (int i = 0; i < Msh.TotalVertexCount; i++) { //Transform the left hand vertices' position by the absolute transform //for the left handbone (which is always bone 10) to render the left hand in place. Msh.TransformedVertices[i].Position = Vector3.Transform(Msh.RealVertices[i].Position, Skel.Bones[Skel.FindBone("L_HAND")].AbsoluteMatrix); //Transform the left hand normals' position by the absolute transform //for the left handbone (which is always bone 10) to render the left hand in place. Msh.TransformedVertices[i].Normal = Vector3.Transform(Msh.RealVertices[i].Normal, Skel.Bones[Skel.FindBone("L_HAND")].AbsoluteMatrix); } return; case MeshType.RHand: for (int i = 0; i < Msh.TotalVertexCount; i++) { //Transform the right hand vertices' position by the absolute transform //for the right handbone (which is always bone 15) to render the right hand in place. Msh.TransformedVertices[i].Position = Vector3.Transform(Msh.RealVertices[i].Position, Skel.Bones[Skel.FindBone("R_HAND")].AbsoluteMatrix); //Transform the right hand normals' position by the absolute transform //for the right handbone (which is always bone 15) to render the right hand in place. Msh.TransformedVertices[i].Normal = Vector3.Transform(Msh.RealVertices[i].Normal, Skel.Bones[Skel.FindBone("R_HAND")].AbsoluteMatrix); } return; } } /// <summary> /// Advances the frame of an animation for a skeleton used on this mesh. /// </summary> /// <param name="Animation">The animation to advance.</param> /// <param name="TimeDelta">The timedelta of the rendering loop.</param> public void AdvanceFrame(Anim Animation, float TimeDelta) { float Duration = (float)Animation.Motions[0].FrameCount / 30; m_AnimationTime += TimeDelta; m_AnimationTime = m_AnimationTime % Duration; //Loop the animation for (int i = 0; i < Animation.Motions.Count; i++) { int BoneIndex = Skel.FindBone(Animation.Motions[i].BoneName); if (BoneIndex == -1) continue; int Frame = (int)(m_AnimationTime * 30); float FractionShown = m_AnimationTime * 30 - Frame; int NextFrame = (Frame + 1 != Animation.Motions[0].FrameCount) ? Frame + 1 : 0; if (Animation.Motions[i].HasTranslation) { Vector3 Translation = new Vector3( Animation.Translations[Frame + Animation.Motions[i].FirstTranslationIndex, 0], Animation.Translations[Frame + Animation.Motions[i].FirstTranslationIndex, 1], Animation.Translations[Frame + Animation.Motions[i].FirstTranslationIndex, 2]); Vector3 NextTranslation = new Vector3( Animation.Translations[NextFrame + Animation.Motions[i].FirstTranslationIndex, 0], Animation.Translations[NextFrame + Animation.Motions[i].FirstTranslationIndex, 1], Animation.Translations[NextFrame + Animation.Motions[i].FirstTranslationIndex, 2]); Vector3 UpdatedTranslation = new Vector3(); UpdatedTranslation.X = (1 - FractionShown) * Translation.X + FractionShown * NextTranslation.X; UpdatedTranslation.Y = (1 - FractionShown) * Translation.Y + FractionShown * NextTranslation.Y; UpdatedTranslation.Z = (1 - FractionShown) * Translation.Z + FractionShown * NextTranslation.Z; Skel.Bones[BoneIndex].Translation = UpdatedTranslation; } if (Animation.Motions[i].HasRotation) { Quaternion Rotation = new Quaternion( Animation.Rotations[Frame + Animation.Motions[i].FirstRotationIndex, 0], Animation.Rotations[Frame + Animation.Motions[i].FirstRotationIndex, 1], Animation.Rotations[Frame + Animation.Motions[i].FirstRotationIndex, 2], Animation.Rotations[Frame + Animation.Motions[i].FirstRotationIndex, 3]); Quaternion NextRotation = new Quaternion( Animation.Rotations[NextFrame + Animation.Motions[i].FirstRotationIndex, 0], Animation.Rotations[NextFrame + Animation.Motions[i].FirstRotationIndex, 1], Animation.Rotations[NextFrame + Animation.Motions[i].FirstRotationIndex, 2], Animation.Rotations[NextFrame + Animation.Motions[i].FirstRotationIndex, 3]); //Use Slerp to interpolate float W1, W2 = 1.0f; float CosTheta = Helpers.DotProduct(Rotation, NextRotation); if (CosTheta < 0) { CosTheta = -1; W2 = -1; } float Theta = (float)Math.Acos(CosTheta); float SinTheta = (float)Math.Sin(Theta); if (SinTheta > 0.001f) { W1 = (float)Math.Sin((1.0f - FractionShown) * Theta) / SinTheta; W2 = (float)Math.Sin(FractionShown Theta) / SinTheta; } else { W1 = 1.0f - FractionShown; W2 = FractionShown; } Quaternion UpdatedRotation = new Quaternion(); UpdatedRotation.X = W1 * Rotation.X + W2 * NextRotation.X; UpdatedRotation.Y = W1 * Rotation.Y + W2 * NextRotation.Y; UpdatedRotation.Z = W1 * Rotation.Z + W2 * NextRotation.Z; UpdatedRotation.W = W1 * Rotation.W + W2 * NextRotation.W; Skel.Bones[BoneIndex].Rotation.X = UpdatedRotation.X; Skel.Bones[BoneIndex].Rotation.Y = UpdatedRotation.Y; Skel.Bones[BoneIndex].Rotation.Z = UpdatedRotation.Z; Skel.Bones[BoneIndex].Rotation.W = UpdatedRotation.W; } } } /// <summary> /// Computes the absolute positions for all bones in a Skeleton. /// </summary> /// <param name="bone">The first bone in the skeleton.</param> /// <param name="world">World matrix.</param> public void ComputeBonePositions(Bone bone, Matrix world) { var translateMatrix = Matrix.CreateTranslation(bone.Translation); var rotationMatrix = Helpers.FindQuaternionMatrix(bone.Rotation); var myWorld = (rotationMatrix * translateMatrix) * world; bone.AbsolutePosition = Vector3.Transform(Vector3.Zero, myWorld); bone.AbsoluteMatrix = myWorld; foreach (var child in bone.Children) { ComputeBonePositions(child, myWorld); } } public void Dispose() { Dispose(true); GC.SuppressFinalize(this); } protected virtual void Dispose(bool CleanUpManagedResources) { if (CleanUpManagedResources) { if(m_AccessoryEffect != null) m_AccessoryEffect.Dispose(); if(m_BodyEffect != null) m_BodyEffect.Dispose(); if(m_HeadEffect != null) m_HeadEffect.Dispose(); if(m_LeftHandEffect != null) m_LeftHandEffect.Dispose(); } } } } --v -=-=- Afr0 Games Project Dollhouse on Github - Please fork!
Sun, 13 Aug 2017, 06:52
shroom_monk	I don't have much experience with C# or HLSL, but have done some rendering stuff with C++ and GLSL before. I'm a little dubious of the way you're calculating your WorldMatrix, specifically: m_World = Matrix.CreateRotationX(m_RotateX) * Matrix.CreateRotationY(m_RotateY) * Matrix.CreateRotationZ(m_RotateZ) * Matrix.CreateScale(m_Scale) * Matrix.CreateTranslation(m_Position); --v In matrix multiplication, ordering matters. Transformations represented by matrices are composed by pre-multiplication, so my reading is that this first translates your object, then scales it, then rotates around the Z axis, then around the Y axis, then around the X axis. So if e.g. your scale transformation is not 1,1,1, then your translation will be wrong, and e.g. any non-zero rotation in your X axis will make your Y and Z axis rotations not seem to be around the axes you expect. Hard to say without seeing the code in action and knowing what you're aiming for, but that's where I'd look first. -=-=- A mushroom a day keeps the doctor away... Keep It Simple, Shroom!
Sun, 13 Aug 2017, 07:29
Afr0	Here's my code in action: This is what I'm aiming for (for some reason it won't play in the Youtube-player on Socoder) I'll try to check for any non-zero rotation in my X-axis. Thanks! -=-=- Afr0 Games Project Dollhouse on Github - Please fork!
Sun, 13 Aug 2017, 07:48
Jayenkai	Looking at the lady's head, why are you even moving the head on its own? I'd've thought the head would be a child of the body, and that simply rotating the body would be enough? -=-=- ''Load, Next List!''
Sun, 13 Aug 2017, 08:12
shroom_monk	Well, non-zero X axis rotation was just one example of how that equation might not give you the results you're expecting, but unless C# multiplies matrices back to front I suspect the whole equation is a broken. You should rotate and scale before translating, and really only have one, well-understood rotation matrix. Having three rotations around world-space axes is likely to cause confusion. I'm also not quite sure why all the individual bones need to be hard-coded like you're doing. It seems to result in a lot of duplicated code which I'm having a bit of difficulty following. I think the normal approach for skeletal animation is to have each model vertex associated with a bone (or multiple bones with blending weights), each bone having an associated local-space transform and parent, then calculate each bone's world-space location cpu-side for the current animation frame and pass that to the shader to do the final skinning. This lets you have a single code path for all your skeleton / animation / skinning stuff without needing to have actual code dedicated to each hand, head, etc. -=-=- A mushroom a day keeps the doctor away... Keep It Simple, Shroom!
Sun, 13 Aug 2017, 10:16
Afr0	I tried doing this: /// <summary> /// This avatar's world matrix. Used for rendering. /// </summary> public Matrix WorldMatrix { get { if (m_WorldIsDirty) { m_World = Matrix.CreateTranslation(m_Position) * Matrix.CreateScale(m_Scale) * Matrix.CreateRotationX(m_RotateX) * Matrix.CreateRotationY(m_RotateY) * Matrix.CreateRotationZ(m_RotateZ); m_WorldIsDirty = false; } return m_World; } } --v but it seems to have no effect! The reason you're likely having trouble following the code is because I left the CPU code in there. I'm only adding GPU rendering as an option for modern computers. -=-=- Afr0 Games Project Dollhouse on Github - Please fork!
Sun, 13 Aug 2017, 13:18
shroom_monk	If most of the components of the calculation are identities (i.e. 0 rotation, scale factor 1, no translation) for the example you're running, there may not be any obvious effect. But in the general case, they are certainly quite different calculations. In terms of identifying what your problem actually is, alas I can't run your code since I don't have a C# environment. I guess the next thing I'd recommend would be to write down what you think the maths is doing, from beginning to end. That is to say, starting from the input data (models, bones, animations, whatever), how you think that is being processed by the code, up to the end result. From there it will probably be easier to tell whether the problem is the maths, or the code that implements the maths. -=-=- A mushroom a day keeps the doctor away... Keep It Simple, Shroom!
Sun, 13 Aug 2017, 13:29
Afr0	Thanks