Stuck in a loop (aka yet another stupid question from spinal)

-=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- (c) WidthPadding Industries 1987 0\|656\|0 -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=- -=+=-
Socoder -> C/C++/C#/Other -> Stuck in a loop (aka yet another stupid question from spinal)
Sat, 17 Nov 2007, 19:06
spinal	My head hurts, this stupid txt reader won't exit. Can someone take a look and tell me whats jamming it? This sort of thing would be a lot easier if I knew what I was doing. void show_text_file(char filename[255], long length_of_file) { // filename="book.txt"; PA_ResetBgSys(); PA_Init8bitBg(0, 3); // Init a 8 bit Bg on screen 0 PA_Init8bitBg(1, 3); // Init a 8 bit Bg on screen 1 // PA_Clear8bitBg(0); // PA_Clear8bitBg(1); PA_8bitCustomFont(5, bigfont); int screen = 1; // which screen to use char filetext[100]; // read 100 characters at a time int font_number=2; // use font number 1 int orientation=3; // 2=normal 3=flipped right, 4=flipped left police8bitheight[5]=10;// manually set the hieght of the custom font, cos it doesnt recognise it PA_Load8bitBgPal(0, (void)bigfont_Pal); PA_Load8bitBgPal(1, (void)bigfont_Pal); long current_pos=0; FILE* testRead = fopen (filename, "rb"); //rb = read // character x and y int lx=5,ly=police8bitheight[font_number]; int temp=0,temp1=0; int length_of_word=0; // how many pixels long the word is long amount_to_read; int exxit=0; while(current_pos<length_of_file-1 && exxit==0) { PA_SmartText(1,0,0,182,240,"1st loop",1,font_number,orientation,100); amount_to_read = length_of_file - current_pos; if(amount_to_read>200)amount_to_read=200; fread(filetext, 1,amount_to_read, testRead);// read 100 bytes of text file bool isword=false; temp=0; char wurd[200]={0}; // use a char for each word temp=0; while(temp<amount_to_read && exxit==0) { PA_SmartText(1,0,0,182,240,"2nd loop",1,font_number,orientation,100); // PA_WaitForVBL(); if(Pad.Held.B){exxit=1;} sprintf(filename,"%d",exxit); PA_SmartText(1,100,0,182,240,filename,1,font_number,orientation,100); // PA_OutputText(0,0,0,"%d",exxit); isword=false; length_of_word=pa8bitdefaultsize[font_number][' ']; while(isword==false) {// 32 = space 13=carrage return 10=linefeed if(filetext[temp]!=32 && filetext[temp]!=10 && filetext[temp]!=13 && temp<amount_to_read) // if current letter is not space { wurd[temp1]=filetext[temp]; // coppy current letter to word length_of_word+=pa8bitdefaultsize[font_number][(u8)wurd[temp1]]; // update length accordingly temp++; temp1++; current_pos++; }else{ wurd[temp1]=0; // terminate the string isword=true; // tell loop a word is found temp1=0; temp++; current_pos++; } if(filetext[temp]==10) { lx=5; ly+=police8bitheight[font_number]; } if(filetext[temp]==13) { int number_of_lines=0; while(filetext[temp]==13 && temp<amount_to_read) { current_pos++; number_of_lines++; temp+=1; } if(number_of_lines>1)number_of_lines=1; lx=5; ly+=police8bitheight[font_number]*number_of_lines; } } if(lx+length_of_word<=182) // if we are still on the screen { // draw the word and update position PA_SmartText(screen,lx,ly,182,240,wurd,1,font_number,orientation,100); lx+=length_of_word; }else{ //if we are not on the screen, move down a line ly+=police8bitheight[font_number]; lx=5; PA_SmartText(screen,lx,ly,182,240,wurd,1,font_number,orientation,100); lx+=length_of_word; length_of_word=0; } if(ly+police8bitheight[font_number]>240) { if(screen==1) { lx=5; ly=police8bitheight[font_number]; screen=0; }else{ int ok_to_exit=0; while(!ok_to_exit) { PA_SmartText(1,0,0,182,240,"3rd loop",1,font_number,orientation,100); PA_WaitForVBL(); if(Pad.Newpress.A){ok_to_exit=1;} } // PA_Clear8bitBg(0); // PA_Clear8bitBg(1); lx=5; ly=police8bitheight[font_number]; screen=1; } } }// temp<100 }//current_pos fclose(testRead); } --v -=-=- Check out my excellent homepage!
Sat, 17 Nov 2007, 19:30
Jayenkai	That's far too baffling at this time of night! I'll have a proper look at it all in the morning. (sorry!) -=-=- ''Load, Next List!''
Sun, 18 Nov 2007, 03:18
power mousey	have you set up debugging methods and run step by step methods to print the values of such variables and qualities like 'exxit' and also 'current_pos' and 'length_of_file-1' and perhaps other ones too?? okay, one thing I see is this: if the Pad.Held.B is true then exxit=1 which I assume will mean to exit...is this corect?? yet, what about those 2 while statements?? while(current_pos<length_of_file-1 && exxit==0) while(temp<amount_to_read && exxit==0)
Sun, 18 Nov 2007, 04:46
spinal	The aim there is that once exit is true (1) then each while will give up what its doing and the function should end. As soon as exxit != 0 then the whole thing should end. -=-=- Check out my excellent homepage!
Sun, 18 Nov 2007, 05:16
Jayenkai	I can't see anything obviously wrong with it. My only complaint is that the Pad.Held.B bit is in the Read-file loop, which only occurs every so often. Perhaps placing that down in the main loop next to the Newpress.a bit might give better results. if(Pad.Newpress.A){ok_to_exit=1;} if(Pad.Held.B){ok_to_exit=1; exxit=1;} ? -=-=- ''Load, Next List!''
Sun, 18 Nov 2007, 05:22
spinal	Tried that first, didn't work.
Sun, 18 Nov 2007, 05:29
spinal	while(current_pos<length_of_file-1 && exxit==0) { PA_SmartText(1,0,0,182,240,"1st loop",1,font_number,orientation,100); amount_to_read = length_of_file - current_pos; if(amount_to_read>200)amount_to_read=200; fread(filetext, 1,amount_to_read, testRead);// read 100 bytes of text file bool isword=false; temp=0; char wurd[200]={0}; // use a char for each word temp=0; while(temp<amount_to_read && exxit==0) { PA_SmartText(1,0,0,182,240,"2nd loop",1,font_number,orientation,100); // PA_WaitForVBL(); sprintf(filename,"%d",exxit); PA_SmartText(1,100,0,182,240,filename,1,font_number,orientation,100); // PA_OutputText(0,0,0,"%d",exxit); isword=false; length_of_word=pa8bitdefaultsize[font_number][' ']; while(isword==false) {// 32 = space 13=carrage return 10=linefeed if(filetext[temp]!=32 && filetext[temp]!=10 && filetext[temp]!=13 && temp<amount_to_read) // if current letter is not space { wurd[temp1]=filetext[temp]; // coppy current letter to word length_of_word+=pa8bitdefaultsize[font_number][(u8)wurd[temp1]]; // update length accordingly temp++; temp1++; current_pos++; }else{ wurd[temp1]=0; // terminate the string isword=true; // tell loop a word is found temp1=0; temp++; current_pos++; } if(filetext[temp]==10) { lx=5; ly+=police8bitheight[font_number]; } if(filetext[temp]==13) { int number_of_lines=0; while(filetext[temp]==13 && temp<amount_to_read) { current_pos++; number_of_lines++; temp+=1; } if(number_of_lines>1)number_of_lines=1; lx=5; ly+=police8bitheight[font_number]number_of_lines; } } if(lx+length_of_word<=182) // if we are still on the screen { // draw the word and update position PA_SmartText(screen,lx,ly,182,240,wurd,1,font_number,orientation,100); lx+=length_of_word; }else{ //if we are not on the screen, move down a line ly+=police8bitheight[font_number]; lx=5; PA_SmartText(screen,lx,ly,182,240,wurd,1,font_number,orientation,100); lx+=length_of_word; length_of_word=0; } if(ly+police8bitheight[font_number]>240) { if(screen==1) { lx=5; ly=police8bitheight[font_number]; screen=0; }else{ int ok_to_exit=0; while(!ok_to_exit) { PA_SmartText(1,0,0,182,240,"3rd loop",1,font_number,orientation,100); PA_WaitForVBL(); if(Pad.Newpress.A){ok_to_exit=1;} if(Pad.Held.B){ok_to_exit=1; exxit=1;} } // PA_Clear8bitBg(0); // PA_Clear8bitBg(1); lx=5; ly=police8bitheight[font_number]; screen=1; } PA_SmartText(1,0,0,182,240,"exited 3rd loop",1,font_number,orientation,100); } PA_SmartText(1,0,0,182,240,"exited 2rd loop",1,font_number,orientation,100); }// temp<100 PA_SmartText(1,0,0,182,240,"exited 1rd loop",1,font_number,orientation,100); }//current_pos PA_SmartText(1,0,0,182,240,"exited function",1,font_number,orientation,100); fclose(testRead); } --v Couple of changes, and I'm getting "exited function" at the top of my screen, so it does seem* to finish the function, but it does not return to my menu -=-=- Check out my excellent homepage!
Sun, 18 Nov 2007, 05:34
Jayenkai	Aaah, well then in that case it's something in the menu that's at fault. It must be constantly re-calling the reader function. This is an assumption, and although it feels like it could be right, it might not be! -=-=- ''Load, Next List!''
Sun, 18 Nov 2007, 05:42
spinal	If your not doing much, I can send you the latest full source for the menu, see if you can spot anything. I'm going to drop into mud chat for a while. \|edit\| It isn't actually exiting the function (that I can tell) The first thing its supposed to do after the txt reader is reload the bottom screen gif, it doesn't do that, it just freezes. -=-=- Check out my excellent homepage!
Sun, 18 Nov 2007, 09:10
power mousey	okay, I'm beggining to see a little of whats going on. But doesn't && mean and. And if it does, then lets say you initiate that Pad.Held.B for exit...and exxit=1 then in those while loops...lets say current_pos is still less than length_of_file-1 also that temp is still less than amount_to_read just curious and wondering too.
Sun, 18 Nov 2007, 09:17
Jayenkai	while (This AND That) So, basically as soon as exxit becomes 1, the loop is broken, because (This AND That) is no longer true. -=-=- ''Load, Next List!''
Sun, 18 Nov 2007, 09:22
power mousey	duh! duh!! on me. thanks Jay, haven't coded in C/C++ for such a long time. I um forgot. I thought it meant Or.